Fixed false logging warning#273
Merged
jstasiak merged 1 commit intopython-zeroconf:masterfrom Jun 2, 2020
Merged
Conversation
…to warn about not making progress.
jstasiak
pushed a commit
that referenced
this pull request
Jun 2, 2020
When there is nothing to write, we don't need to warn about not making progress.
This was referenced Jun 4, 2020
Member
Author
|
Thanks!
…On Fri, Jun 5, 2020, 5:22 AM J. Nick Koston ***@***.***> wrote:
Verified the spurious warning is fixed in 0.27.1
Thanks @gjbadros <https://github.com/gjbadros> and @jstasiak
<https://github.com/jstasiak>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#273 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALOHTIIG44DSW5O5S5W5STRVDPPVANCNFSM4NQMLAIA>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when there is nothing to write, we don't need to warn about not making progress.