Test: assert len(ctrls) & remove a magic number

SOMA Yuki · SOMA Yuki · commit a0ba39936028 · 2018-11-21T16:12:42.000+09:00
diff --git a/Tests/t_ldapobject.py b/Tests/t_ldapobject.py
@@ -170,8 +170,11 @@ def test_response_controls_are_attached_to_exceptions(self):
                 serverctrls=[ldap.controls.ppolicy.PasswordPolicyControl()])
 
         controls = cm.exception.args[0]['ctrls']
-        pp = ldap.controls.DecodeControlTuples(controls)[0]
-        self.assertEqual(pp.error, 1)  # error == 1 means AccountLockout
+        decoded_controls = ldap.controls.DecodeControlTuples(controls)
+        self.assertEqual(len(decoded_controls), 1)
+        pp = decoded_controls[0]
+        expected_error = ldap.controls.ppolicy.PasswordPolicyError('accountLocked')
+        self.assertEqual(pp.error, int(expected_error))
 
 
 class Test00_SimpleLDAPObject(SlapdTestCase):
