Skip to content

Make timeout adjustable - #494

Merged
rytilahti merged 2 commits into
python-kasa:masterfrom
bdraco:connecton_timeout
Oct 7, 2023
Merged

Make timeout adjustable#494
rytilahti merged 2 commits into
python-kasa:masterfrom
bdraco:connecton_timeout

Conversation

@bdraco

@bdraco bdraco commented Aug 4, 2023

Copy link
Copy Markdown
Member

No description provided.

@codecov-commenter

codecov-commenter commented Aug 4, 2023

Copy link
Copy Markdown

Codecov Report

All modified lines are covered by tests ✅

Files Coverage Δ
kasa/discover.py 84.24% <100.00%> (+0.10%) ⬆️
kasa/protocol.py 86.66% <100.00%> (ø)
kasa/smartbulb.py 91.70% <100.00%> (ø)
kasa/smartdevice.py 87.60% <100.00%> (ø)
kasa/smartdimmer.py 84.44% <100.00%> (ø)
kasa/smartlightstrip.py 93.47% <100.00%> (ø)
kasa/smartplug.py 100.00% <100.00%> (ø)
kasa/smartstrip.py 87.19% <100.00%> (ø)

📢 Thoughts on this report? Let us know!.

@rytilahti

Copy link
Copy Markdown
Member

@bdraco should this be de-drafted to be included in the next upcoming release?

@bdraco

bdraco commented Oct 4, 2023

Copy link
Copy Markdown
Member Author

I need to write tests for it, but I'm been really short on time since I've been traveling so much (haven't been the same timezone for more than a few days at a time over the last 30 days) so I haven't had a chance to get back to these.

@rytilahti rytilahti added this to the 0.5.4 milestone Oct 4, 2023
@rytilahti rytilahti added the enhancement New feature or request label Oct 4, 2023
@rytilahti

Copy link
Copy Markdown
Member

No worries, just wanted to give a friendly ping :-) I think it's for the best to delay a new release to get your open PRs (and hopefully #509, too) in.

@bdraco

bdraco commented Oct 4, 2023

Copy link
Copy Markdown
Member Author

I should be home for the latter end of next week unless something comes up. Once I catch up on sleep, I'll try to catch up on all my PR backlog

@bdraco
bdraco force-pushed the connecton_timeout branch from 8697770 to 0c97da5 Compare October 7, 2023 17:29
@bdraco
bdraco marked this pull request as ready for review October 7, 2023 17:36

@rytilahti rytilahti left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @bdraco! 👍

We should probably add a cli parameter for this, but that can be done in a separate PR. Related to #310.

@rytilahti
rytilahti merged commit 0ec0826 into python-kasa:master Oct 7, 2023
@bdraco
bdraco deleted the connecton_timeout branch October 7, 2023 19:07
@rytilahti rytilahti mentioned this pull request Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants