dump_devinfo: camelCase vacuum commands #1322
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1322 +/- ##
=======================================
Coverage 92.13% 92.13%
=======================================
Files 119 119
Lines 7619 7619
Branches 794 794
=======================================
Hits 7020 7020
Misses 441 441
Partials 158 158 ☔ View full report in Codecov by Sentry. |
This was referenced Nov 29, 2024
rytilahti
commented
Nov 30, 2024
| SmartRequest.get_raw_request("get_map_info"), | ||
| SmartRequest.get_raw_request("get_map_data"), | ||
| SmartRequest.get_raw_request("getMapInfo"), | ||
| SmartRequest.get_raw_request("getMapData"), |
Member
Author
There was a problem hiding this comment.
This errors currently as it requires the map id (-1 for the last clean).
sdb9696
approved these changes
Dec 1, 2024
Member
Author
|
Oopsie, I inadvertently merged the transport PR with those commits... Well, now that these are already in, I think we can just close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The device does not support automatic conversion from snake_case to camelCase, so I think we should follow the "standard".
This is just a squashed cherry-pick of 964b0f1 and d1713df to keep the transport PR clean.