WIP: migrate to asyncio and httpx #998
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
convert more functions to async and add a async_ prefix for them add sync functions for the async ones
fix typo in v4/objects.py add a async __setup__ to call after init is run
Author
|
at the moment the httpx module dose not support |
Member
|
Thanks for all the efforts on this. Maybe we should wait until the 1.0 release of https in April?
|
Author
|
yeah probably hopefully they fix the two issues that are blocking this pr |
|
Can you check if httpx version 1.0.0.beta0 fixes the remaining issues? |
Member
|
No activity in almost two years from the author. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
starting to migrate to async while staying compatible to the syncronous versions.
TODO:
which funktions are suposed to be called by the user? if possible i would like to keep all internal funktions async and run the functions that have to be sync with
run_until_complete()would it be better to have a centrel event_loop instead of getting it with
get_event_loopevery time and if so where would i put it?fix #945