Skip to content

Conversation

@JohnVillalovos
Copy link
Member

The documentation incorrectly showed calling start() on the ProjectPullMirror object (mirror.start()), but the method only exists on the ProjectPullMirrorManager. Updated the example to show the correct usage: project.pull_mirror.start().

Fixes #3269

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes incorrect documentation for the pull mirror start() method by correcting the example to show the proper API usage through the manager object rather than directly on the mirror instance.

  • Corrected the start() method invocation from mirror.start() to project.pull_mirror.start()
  • Fixed grammar from "an sync" to "a sync" in the documentation comment

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@JohnVillalovos JohnVillalovos force-pushed the jlvillal/3269_pull_mirror branch 3 times, most recently from 8d1efa1 to aa1ac3d Compare October 17, 2025 20:51
@nejch nejch enabled auto-merge (rebase) October 17, 2025 21:10
The documentation incorrectly showed calling start() on the
ProjectPullMirror object (mirror.start()), but the method only
exists on the ProjectPullMirrorManager. Updated the example to
show the correct usage: project.pull_mirror.start().

Fixes #3269
@JohnVillalovos JohnVillalovos force-pushed the jlvillal/3269_pull_mirror branch from aa1ac3d to 9a4b655 Compare October 17, 2025 21:18
@nejch nejch merged commit 2acac19 into main Oct 17, 2025
17 checks passed
@nejch nejch deleted the jlvillal/3269_pull_mirror branch October 17, 2025 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pull_mirror does not provide start()

3 participants