ci(gitlab-ci): create 'codestyle' job for GitLab CI/CD and local usage #3266
+16
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adrian DC <radian.dc@gmail.com>
Member
|
Hey @AdrianDC thanks for the PR. Since this doesn't normally run here (it would only normally run in our GitLab mirror at https://gitlab.com/python-gitlab/python-gitlab where we run Docker image deploys), maybe instead we should address the root cause: is there a specific reason you need to maintain a long-living fork, other than delays in getting PRs merged upstream here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Documentation and testing
Please consider whether this PR needs documentation and tests. This is not required, but highly appreciated:
Thought about it due to feat(users): implement 'skip_confirmation' in users 'emails' creation #3265,
where I ran the codestyle documented functions from an Alpine container,
but took a different approach here to match 100% the GitHub workflow (for seamless maintenance reasons),
meant for GitLab CI/CD forks / rehostes, and if interested for local usage (gcil)
PR denial is OK, will probably keep it on my fork anyways for future patch PR checks