Skip to content

fix(api): use ID instead of name for GroupLabel & ProjectLabel _id_attr #2811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ptalbert wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −2
Draft

fix(api): use ID instead of name for GroupLabel & ProjectLabel _id_attr #2811

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions gitlab/v4/objects/labels.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@


class GroupLabel(SubscribableMixin, SaveMixin, ObjectDeleteMixin, RESTObject):
_id_attr = "name"
_id_attr = "id"
_repr_attr = "name"
manager: "GroupLabelManager"

# Update without ID, but we need an ID to get from list.
Expand Down Expand Up @@ -87,7 +88,8 @@ def update( # type: ignore
class ProjectLabel(
PromoteMixin, SubscribableMixin, SaveMixin, ObjectDeleteMixin, RESTObject
):
_id_attr = "name"
_id_attr = "id"
_repr_attr = "name"
manager: "ProjectLabelManager"

# Update without ID, but we need an ID to get from list.
Expand Down