Skip to content

Fix get_proxy_url adding unnecessary '/' #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mingchen merged 1 commit into from
Sep 29, 2021
Merged

Fix get_proxy_url adding unnecessary '/' #41

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions cas.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ def get_login_url(self):
params.update(self.extra_login_params)
url = urllib_parse.urljoin(self.server_url, 'login')
query = urllib_parse.urlencode(params)
return url + '?' + query
return ''.join([url, '?', query])

def get_logout_url(self, redirect_url=None):
"""Generates CAS logout URL
Expand All @@ -115,7 +115,8 @@ def get_logout_url(self, redirect_url=None):
url = urllib_parse.urljoin(self.server_url, 'logout')
if redirect_url:
params = {self.logout_redirect_param_name: redirect_url}
url += '?' + urllib_parse.urlencode(params)
query = urllib_parse.urlencode(params)
return ''.join([url, '?', query])
return url

def get_proxy_url(self, pgt):
Expand All @@ -124,8 +125,10 @@ def get_proxy_url(self, pgt):
Returns:
str: Proxy URL
"""
params = urllib_parse.urlencode({'pgt': pgt, 'targetService': self.service_url})
return "%s/proxy?%s" % (self.server_url, params)
params = {'pgt': pgt, 'targetService': self.service_url}
url = urllib_parse.urljoin(self.server_url, 'proxy')
query = urllib_parse.urlencode(params)
return ''.join([url, '?', query])

def get_proxy_ticket(self, pgt):
"""Get proxy ticket given the proxy granting ticket
Expand Down