Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1164 +/- ##
=======================================
Coverage 91.31% 91.31%
=======================================
Files 27 27
Lines 4638 4654 +16
=======================================
+ Hits 4235 4250 +15
- Misses 403 404 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Member
|
I'll try to take a look later today :) |
tomasr8
reviewed
Jan 8, 2025
Member
tomasr8
left a comment
There was a problem hiding this comment.
Nice! I left you some comments :)
Hopefully I didn't miss anything with so many similar changes 😅
akx
added a commit
that referenced
this pull request
Feb 3, 2025
akx
added a commit
that referenced
this pull request
Feb 3, 2025
radermacher-iits
pushed a commit
to kubara-io/kubara
that referenced
this pull request
Feb 19, 2026
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [babel](https://babel.pocoo.org/) ([source](https://github.com/python-babel/babel)) | packages | minor | `==2.17.0` → `==2.18.0` | --- ### Release Notes <details> <summary>python-babel/babel (babel)</summary> ### [`v2.18.0`](https://github.com/python-babel/babel/blob/HEAD/CHANGES.rst#Version-2180) [Compare Source](python-babel/babel@v2.17.0...v2.18.0) Happy 2026! This release is, coincidentally, also being made from FOSDEM. We will aspire for a slightly less glacial release cadence in this year; there are interesting features in the pipeline. Features ``` * Core: Add `babel.core.get_cldr_version()` by @​akx in :gh:`1242` * Core: Use CLDR 47 by @​tomasr8 in :gh:`1210` * Core: Use canonical IANA zone names in zone_territories by @​akx in :gh:`1220` * Messages: Improve extract performance via ignoring directories early during os.walk by @​akx in :gh:`968` * Messages: Merge in per-format keywords and auto_comments by @​akx in :gh:`1243` * Messages: Update keywords for extraction of dpgettext and dnpgettext by @​mardiros in :gh:`1235` * Messages: Validate all plurals in Python format checker by @​tomasr8 in :gh:`1188` * Time: Use standard library `timezone` instead of `FixedOffsetTimezone` by @​akx in :gh:`1203` Bugfixes ``` - Core: Fix formatting for "Empty locale identifier" exception added in [#​1164](python-babel/babel#1164) by [@​akx](https://github.com/akx) in :gh:`1184` - Core: Improve handling of no-inheritance-marker in timezone data by [@​akx](https://github.com/akx) in :gh:`1194` - Core: Make the number pattern regular expression more efficient by [@​akx](https://github.com/akx) in :gh:`1213` - Messages: Keep translator comments next to the translation function call by [@​akx](https://github.com/akx) in :gh:`1196` - Numbers: Fix KeyError that occurred when formatting compact currencies of exactly one thousand in several locales by [@​bartbroere](https://github.com/bartbroere) in :gh:`1246` Other improvements ``` * Core: Avoid unnecessary uses of `map()` by @​akx in :gh:`1180` * Messages: Have init-catalog create directories too by @​akx in :gh:`1244` * Messages: Optimizations for read_po by @​akx in :gh:`1200` * Messages: Use pathlib.Path() in catalog frontend; improve test coverage by @​akx in :gh:`1204` Infrastructure and documentation ``` - CI: Renovate CI & lint tools by [@​akx](https://github.com/akx) in :gh:`1228` - CI: Tighten up CI with Zizmor by [@​akx](https://github.com/akx) in :gh:`1230` - CI: make job permissions explicit by [@​akx](https://github.com/akx) in :gh:`1227` - Docs: Add SECURITY.md by [@​akx](https://github.com/akx) in :gh:`1229` - Docs: Remove u string prefix from docs by [@​verhovsky](https://github.com/verhovsky) in :gh:`1174` - Docs: Update dates.rst with current unicode.org tr35 link by [@​clach04](https://github.com/clach04) in :gh:`1189` - General: Add some PyPI classifiers by [@​tomasr8](https://github.com/tomasr8) in :gh:`1186` - General: Apply reformatting by hand and with Ruff by [@​akx](https://github.com/akx) in :gh:`1202` - General: Test on and declare support for Python 3.14 by [@​akx](https://github.com/akx) in :gh:`1233` - Tests: Convert Unittest testcases with setup/teardown to fixtures by [@​akx](https://github.com/akx) in :gh:`1240` - Tests: Mark PyPy CI flake as xfail by [@​akx](https://github.com/akx) in :gh:`1197` - Tests: Move pytest config to `pyproject.toml` by [@​tomasr8](https://github.com/tomasr8) in :gh:`1187` - Tests: Unwrap most `unittest` test cases to bare functions by [@​akx](https://github.com/akx) in :gh:`1241` </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4zLjYiLCJ1cGRhdGVkSW5WZXIiOiI0My4zLjYiLCJ0YXJnZXRCcmFuY2giOiJtYXN0ZXIiLCJsYWJlbHMiOltdfQ==--> Reviewed-on: https://kubara.git.onstackit.cloud/STACKIT/kubara/pulls/275
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the handling of
Noneas alocale=argument.Namely:
Locale.parse()raises for falsy arguments is more descriptive.Nonefor a public API means "use the default", not "crash on me".Nonelocale, but I hope that sort of code isn't very popular.Fixes #1156.
Closes #1158 (supersedes it).