Doc: Disable smartquotes for zh-tw, fr and ja translations #9423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Tested locally and it works for me. I'll try to get the docs azure builder use the right Sphinx version. We're already using sphinx > 1.7 in production so it's OK. |
Member
|
@adrian Could you bump the sphinx version in |
This is a replacement for python#9337. * Using conf.py to disable smartquotes through Sphinx instead of using docutils.conf * Disable smartquotes for Japanese, French and Traditional Chinese translations See: * Suggesting to use conf.py: https://mail.python.org/pipermail/doc-sig/2018-September/004084.html * Original smartquotes issue in ja translations: https://bugs.python.org/issue31793 * Disabling for ja: python#4006 * Smartquotes issue in fr: python/python-docs-fr#303 * Smartquotes issue in zh_TW: https://mail.python.org/pipermail/doc-sig/2018-August/004079.html
Using smartquotes_excludes option in conf.py requires Sphinx 1.6.6 or more. See: http://www.sphinx-doc.org/en/1.7/config.html#confval-smartquotes_excludes
….yml to 1.7 Disabling smartquotes in conf.py with Sphinx is available in Sphinx 1.7 thus updating the version requirements for building docs on CI.
675534a to
be13af3
Compare
Contributor
Author
|
@JulienPalard Done! |
JulienPalard
pushed a commit
to JulienPalard/cpython
that referenced
this pull request
Nov 5, 2018
…thonGH-9423) (cherry picked from commit c03bf0a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a replacement for #9337 that uses
smartquotes_excludesconfig in conf.py instead of docutils.conf. See the suggestion in https://mail.python.org/pipermail/doc-sig/2018-September/004084.htmlSee also: #4006
@JulienPalard Please test a build with this patch and validate if it fixes the smartquotes issue for French translations.