Skip to content

bpo-42330: Registered browsh in webbrowser module #23289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Yash-Singh1 wants to merge 2 commits into from
Closed

bpo-42330: Registered browsh in webbrowser module #23289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
81c4a36
Added in browsh as a registered webbrowser
Yash-Singh1 Nov 14, 2020
d75cb39
Added browsh into webbrowser docs
Yash-Singh1 Nov 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Doc/library/webbrowser.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,8 @@ for the controller classes, all defined in this module.
+------------------------+-----------------------------------------+-------+
| ``'w3m'`` | :class:`GenericBrowser('w3m')` | |
+------------------------+-----------------------------------------+-------+
| ``'browsh'`` | :class:`GenericBrowser('browsh')` | |
+------------------------+-----------------------------------------+-------+
| ``'windows-default'`` | :class:`WindowsDefault` | \(2) |
+------------------------+-----------------------------------------+-------+
| ``'macosx'`` | :class:`MacOSX('default')` | \(3) |
Expand Down
3 changes: 3 additions & 0 deletions Lib/webbrowser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -573,6 +573,9 @@ def register_standard_browsers():
# The w3m browser <http://w3m.sourceforge.net/>
if shutil.which("w3m"):
register("w3m", None, GenericBrowser("w3m"))
# The browsh browser <https://www.brow.sh/>
if shutil.which("browsh") and shutil.which("firefox"):
register("browsh", None, GenericBrowser(["browsh", "--startup-url", "%s"]))

# OK, now that we know what the default preference orders for each
# platform are, allow user to override them with the BROWSER variable.
Expand Down