Skip to content

bpo-19561: Remove unnecessary gethostname() prototype for Solaris #23208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kulikjak wants to merge 1 commit into from
Closed

bpo-19561: Remove unnecessary gethostname() prototype for Solaris #23208

kulikjak wants to merge 1 commit into from

Conversation

@kulikjak
Copy link
Contributor

@kulikjak kulikjak commented Nov 9, 2020 •
edited by bedevere-bot
Loading

This is no longer necessary because Solaris included gethostname() in its header files more than 15 years ago.

https://bugs.python.org/issue19561

jstasiak
jstasiak approved these changes Nov 12, 2020
View reviewed changes
Copy link
Contributor

@jstasiak jstasiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested this on OpenIndiana, works fine.

@github-actions
Copy link

github-actions bot commented Dec 16, 2020

This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Dec 16, 2020
@kulikjak
Copy link
Contributor Author

kulikjak commented Dec 16, 2020

I cannot remove the stale label, but I am still very interested in this being merged.

@github-actions github-actions bot removed the stale Stale PR or inactive for long period of time. label Dec 17, 2020
@github-actions
Copy link

github-actions bot commented Jan 16, 2021

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Jan 16, 2021
@kulikjak
Copy link
Contributor Author

kulikjak commented Jan 16, 2021

Still relevant...

@github-actions github-actions bot removed the stale Stale PR or inactive for long period of time. label Jan 17, 2021
@kulikjak kulikjak force-pushed the fix-gethostname-declaration branch 3 times, most recently from 3f551bd to d650b0c Compare August 23, 2022 12:03
@iritkatriel iritkatriel requested a review from Yhg1s November 27, 2022 22:52
@arhadthedev
Copy link
Member

arhadthedev commented Mar 22, 2023

@jcea (as an OpenSolaris expert)

@kulikjak kulikjak force-pushed the fix-gethostname-declaration branch from cb868a7 to 93e64c8 Compare May 9, 2023 13:02
@kulikjak kulikjak mentioned this pull request Sep 2, 2023
Merged
@kulikjak kulikjak force-pushed the fix-gethostname-declaration branch from 93e64c8 to d2fc237 Compare September 2, 2023 15:32
@risto3 risto3 mannequin mentioned this pull request Sep 2, 2023
Closed
@vstinner vstinner mentioned this pull request Sep 2, 2023
Merged
@vstinner
Copy link
Member

vstinner commented Sep 2, 2023 •
edited
Loading

I proposed PR #108817 with more details on the issue.

@kulikjak
Copy link
Contributor Author

kulikjak commented Sep 3, 2023

Fixed with #108817.

@kulikjak kulikjak closed this Sep 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Yhg1s Yhg1s Awaiting requested review from Yhg1s

1 more reviewer

@jstasiak jstasiak jstasiak approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting core review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@kulikjak @arhadthedev @vstinner @jstasiak @the-knights-who-say-ni @ezio-melotti @bedevere-bot