bpo-39659: Route calls from pathlib.Path to os.getcwd() via the path accessor #18834
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). CLA MissingOur records indicate the following people have not signed the CLA: For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
|
This change should have no functional effect beyond the addition of |
Lib/pathlib.py
Outdated
There was a problem hiding this comment.
This is a quirky way to implement it. If the accessor becomes tied to the class rather than specific instances, perhaps it should become a class-level attribute?
There was a problem hiding this comment.
It's very similar to how home() is implemented immediately below.
Agree generally that the accessor should be a class attribute and not an instance attribute.
There was a problem hiding this comment.
I've replaced cls() with cls in this method, and home() for consistency.
There was a problem hiding this comment.
Well, that didn't work at all! Looks like:
_accessoris set in_init(), at least until bpo-40038: pathlib: remove partial support for preserving accessor when modifying a path #19342 lands_flavouris set in__new__().
Reverting to previous patch (the one you reviewed).
cfc20dc to
05e73d0
Compare
|
@barneygale This one looks like the conflict is meaningful? (And it's new because I merged one of your other changes, I think) |
05e73d0 to
74abd98
Compare
|
Thank you! Rebased :-) |
(from the bug description:) Whereas most calls to
osfunctions frompathlib.Pathmethods happen viapathlib._Accessormethods, retrieving the current working directory does not. This problem occurs when calling thepathlib.Path.cwd(),~resolve()and~absolute()methods.https://bugs.python.org/issue39659