Skip to content

gh-141004: Document PyType_FastSubclass #141313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ZeroIntensity merged 3 commits into from
Nov 10, 2025
Merged

gh-141004: Document PyType_FastSubclass #141313

ZeroIntensity merged 3 commits into from
Nov 10, 2025

Conversation

@StanFromIreland
Copy link
Member

@StanFromIreland StanFromIreland commented Nov 9, 2025 •
edited by github-actions bot
Loading

I think documenting it as a function is better.

📚 Documentation preview 📚: https://cpython-previews--141313.org.readthedocs.build/

@bedevere-app bedevere-app bot added awaiting review docs Documentation in the Doc dir skip news labels Nov 9, 2025
@github-project-automation github-project-automation bot moved this to Todo in Docs PRs Nov 9, 2025
@bedevere-app bedevere-app bot mentioned this pull request Nov 9, 2025
Open
ZeroIntensity
ZeroIntensity reviewed Nov 10, 2025
View reviewed changes
ZeroIntensity
ZeroIntensity reviewed Nov 10, 2025
View reviewed changes
@StanFromIreland @ZeroIntensity
Apply Peter's suggestion
5d14d2b 
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
ZeroIntensity
ZeroIntensity approved these changes Nov 10, 2025
View reviewed changes
Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

@ZeroIntensity ZeroIntensity added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Nov 10, 2025
@ZeroIntensity ZeroIntensity merged commit ed0a5fd into python:main Nov 10, 2025
36 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Docs PRs Nov 10, 2025
@miss-islington-app
Copy link

miss-islington-app bot commented Nov 10, 2025

Thanks @StanFromIreland for the PR, and @ZeroIntensity for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 10, 2025
@StanFromIreland @ZeroIntensity @miss-islington
pythongh-141004: Document PyType_FastSubclass (pythonGH-141313)
430bfc3 
(cherry picked from commit ed0a5fd)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Nov 10, 2025

GH-141368 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Nov 10, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 10, 2025
@StanFromIreland @ZeroIntensity @miss-islington
pythongh-141004: Document PyType_FastSubclass (pythonGH-141313)
04c9584 
(cherry picked from commit ed0a5fd)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Nov 10, 2025

GH-141369 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Nov 10, 2025
ZeroIntensity added a commit that referenced this pull request Nov 10, 2025
@miss-islington @StanFromIreland @ZeroIntensity
[3.14] gh-141004: Document PyType_FastSubclass (GH-141313) (GH-141368)
96820d8 
gh-141004: Document `PyType_FastSubclass` (GH-141313)
(cherry picked from commit ed0a5fd)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
ZeroIntensity added a commit that referenced this pull request Nov 10, 2025
@miss-islington @StanFromIreland @ZeroIntensity
[3.13] gh-141004: Document PyType_FastSubclass (GH-141313) (GH-141369)
d158413 
gh-141004: Document `PyType_FastSubclass` (GH-141313)
(cherry picked from commit ed0a5fd)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
@StanFromIreland StanFromIreland deleted the PyType_FastSubclass branch November 10, 2025 17:54
@StanFromIreland
Copy link
Member Author

StanFromIreland commented Nov 10, 2025

Thanks!

StanFromIreland added a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
@StanFromIreland @ZeroIntensity
pythongh-141004: Document PyType_FastSubclass (pythonGH-141313)
f57daec 
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZeroIntensity ZeroIntensity ZeroIntensity approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@StanFromIreland @ZeroIntensity