GH-132566: Progressively delete files in pathlib.Path.move()
#133852
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjust `pathlib.Path.move()` so that each file and directory is deleted immediately after it is copied, rather than copying everything before deleting anything. To achieve this, we rename `_copy_from()` to `_iter_copy_from()` and convert it to a generator that yields `(target, source)` pairs. The `Path.move()` method deletes each source path after it's copied.
Contributor
|
Thanks for this! I'll try to take a look asap |
Contributor
Author
|
👍 thanks. FWIW this patch makes |
graingert
approved these changes
May 27, 2025
Contributor
|
sorry for the delay, this looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust
pathlib.Path.move()so that each file and directory is deleted immediately after it is copied, rather than copying everything before deleting anything.To achieve this, we rename
_copy_from()to_iter_copy_from()and convert it to a generator that yields(source, target)path pairs. ThePath.move()method deletes each source path after it's copied.pathlib.Path.move()consumes too much disk space #132566