GH-125413: Add pathlib.Path.scandir() method
#126060
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `pathlib.Path.scandir()` as a trivial wrapper of `os.scandir()`. In the private `pathlib._abc.PathBase` class, we can rework the `iterdir()`, `glob()`, `walk()` and `copy()` methods to call `scandir()` and make use of cached directory entry information, and thereby improve performance. Because the `Path.copy()` method is provided by `PathBase`, this also speeds up traversal when copying local files and directories.
I'll save these for another PR.
Contributor
Author
|
Woot! Thanks very much for your feedback on this, it's been most helpful in clarifying what's needed. |
|
I'm not sure if this is the correct place to put this feedback, but At least on first glance, it's unexpected that a member named "path" on an object returned from a method of Path is not actually of type Path. with path.scandir() as entries:
for entry in entries:
assert isinstance(entry.path, Path), "unexpected type" |
Contributor
Author
|
Would you care to open a topic on discuss.python.org? It's a good thought and worth bringing to wider attention I think. At the moment you can get a path object with |
|
picnixz
pushed a commit
to picnixz/cpython
that referenced
this pull request
Dec 8, 2024
Add `pathlib.Path.scandir()` as a trivial wrapper of `os.scandir()`. This will be used to implement several `PathBase` methods more efficiently, including methods that provide `Path.copy()`.
ebonnal
pushed a commit
to ebonnal/cpython
that referenced
this pull request
Jan 12, 2025
Add `pathlib.Path.scandir()` as a trivial wrapper of `os.scandir()`. This will be used to implement several `PathBase` methods more efficiently, including methods that provide `Path.copy()`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
pathlib.Path.scandir()as a trivial wrapper ofos.scandir().In a future PR, I will rework
pathlib._abc.PathBase.glob(),walk()andcopy()methods to callscandir()and make use of cached directory entry information, and thereby improve performance. Because thePath.copy()method is provided byPathBase, this also speeds up traversal when copying local files and directories.os.DirEntryobjects from pathlib #125413📚 Documentation preview 📚: https://cpython-previews--126060.org.readthedocs.build/