gh-125063: Emit slices as constants in the bytecode compiler #125064
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iritkatriel
reviewed
Oct 7, 2024
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
always has the same net effect
iritkatriel
reviewed
Oct 8, 2024
iritkatriel
approved these changes
Oct 8, 2024
Contributor
Author
|
Here are the largest stat changes:
|
efimov-mikhail
pushed a commit
to efimov-mikhail/cpython
that referenced
this pull request
Oct 9, 2024
…ython#125064) * Make slices marshallable * Emit slices as constants * Update Python/marshal.c Co-authored-by: Peter Bierma <zintensitydev@gmail.com> * Refactor codegen_slice into two functions so it always has the same net effect * Fix for free-threaded builds * Simplify marshal loading of slices * Only return SUCCESS/ERROR from codegen_slice --------- Co-authored-by: Mark Shannon <mark@hotpy.org> Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This emits slices as constants in the compiler (when the slices only contain constant members).
I measured a 10% speedup on the cavity_flow benchmark in npbench, which not surprisingly uses a lot of slices, but this kind of code is fairly idiomatic for Numpy. (EDIT: The benchmark as a standalone script)
This does measure as are 1% slower on pyperformance, but that seems largely due to
unpack_sequence. I'm going to rerun on more platforms, and also collect stats, since I would expect a measurable reduction in instructions executed.