gh-74929: Fix an extra DECREF for PEP 667 implementation #118583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gvanrossum
approved these changes
May 5, 2024
Member
gvanrossum
left a comment
There was a problem hiding this comment.
Maybe you want to delete or update the comment in the test?
Lib/test/test_frame.py
Outdated
| self.assertEqual(o, 'a.b.c') | ||
|
|
||
| def test_update_with_self(self): | ||
| # Make sure reference is not leaking here |
Member
There was a problem hiding this comment.
The problem was not a leak though -- it was a free-after-use (the opposite of a leak, really :-).
Member
Author
There was a problem hiding this comment.
Right. I was imaging a pool of reference and a hole that's leaking the reference without people knowing it so the pool is drained, but yeah leak is not a good word choice here. I just deleted it, the test itself makes sense without any comments.
Member
There was a problem hiding this comment.
Ooh, that's actually a nice image. :-) I will merge now.
Member
Author
There was a problem hiding this comment.
Thanks for the quick review!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the PEP 667 implementation, when I copied the code from
_PyFrame_LocalsToFast, I did not realize thevalueis a new reference so it was decrefed in the original code. This resulted in an extra DECREF in__setitem__. Unfortunately I did not catch it because the test cases used were all immortals.Two test cases were added:
f_localsupdating itself multiple times - this will crash the interpreter without the fix