Docs: upgrade to python-docs-theme 2023.7 #107617
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hauntsaninja
approved these changes
Aug 4, 2023
AA-Turner
approved these changes
Aug 4, 2023
Member
AA-Turner
left a comment
There was a problem hiding this comment.
We could potentially do >=2023.7, but fairly minor.
A
Member
Author
|
Good idea, I'll update it to |
Contributor
|
Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
Contributor
|
Sorry, @hugovk, I could not cleanly backport this to |
Contributor
|
Sorry, @hugovk, I could not cleanly backport this to |
hugovk
added a commit
to hugovk/cpython
that referenced
this pull request
Aug 4, 2023
(cherry picked from commit 19f32b2) Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
|
GH-107633 is a backport of this pull request to the 3.12 branch. |
|
GH-107634 is a backport of this pull request to the 3.11 branch. |
hugovk
added a commit
to hugovk/cpython
that referenced
this pull request
Aug 4, 2023
(cherry picked from commit 19f32b2) Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Yhg1s
pushed a commit
that referenced
this pull request
Aug 4, 2023
hugovk
added a commit
that referenced
this pull request
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The venv used on the docs server persists between deploys, therefore let's pin the theme so we get the version we want:
This means we'll get the dark theme for 3.11 (aka the main https://docs.python.org/3/). We've already had it on https://docs.python.org/3.12/ and https://docs.python.org/3.13/ for a few months.
Let's also bump Sphinx to include the latest 6.x patch release:
(We have another PR to upgrade Sphinx to 7.x, let's handle that separately: #99381)
📚 Documentation preview 📚: https://cpython-previews--107617.org.readthedocs.build/