Docs: Fix getstatus() -> getcode() typos #101296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
Contributor
|
Sorry @hugovk, I had trouble checking out the |
|
GH-101804 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 10, 2023
(cherry picked from commit 61f2be0) Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
|
GH-101805 is a backport of this pull request to the 3.11 branch. |
hugovk
added a commit
to hugovk/cpython
that referenced
this pull request
Feb 10, 2023
carljm
added a commit
to carljm/cpython
that referenced
this pull request
Feb 10, 2023
* main: Docs: Fix getstatus() -> getcode() typos (python#101296) Docs: use parameter list for sqlite3.Cursor.execute* (python#101782) pythongh-101763: Update bundled copy of libffi to 3.4.4 on Windows (pythonGH-101784) pythongh-101517: make bdb avoid looking up in linecache with lineno=None (python#101787) pythongh-101759: Update Windows installer to SQLite 3.40.1 (python#101762) pythongh-101277: Finalise isolating itertools (pythonGH-101305) pythongh-101759: Update macOS installer to SQLite 3.40.1 (python#101761)
miss-islington
added a commit
that referenced
this pull request
Feb 10, 2023
(cherry picked from commit 61f2be0) Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
hugovk
added a commit
that referenced
this pull request
Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docs say
getstatus()forhttp.client.HTTPResponseandurllib.response.addinfourl:But they're really
getcode():cpython/Lib/http/client.py
Lines 778 to 783 in f02fa64
cpython/Lib/urllib/response.py
Lines 80 to 81 in f02fa64
The documentation (and typos) for these were added as part of #11447 for Python 3.9 in 2019, although the methods have been around much longer (2009 and 2008).
Let's backport to at least 3.10.