gh-111744: Make breakpoint() enter the debugger immediately
#118579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Haha. Away from my computer now, but I’ll take a look at this today. |
Member
Author
Pun is actually not intended. Took me a second to realize what's funny :) |
Contributor
|
This is a breaking change but I can't tell you how many times I wanted to look at the state of a function, I put So this is great to see! |
brandtbucher
reviewed
May 4, 2024
brandtbucher
reviewed
May 4, 2024
Member
|
Test changes look good. Thanks for applying a variety of fixes there. |
brandtbucher
approved these changes
May 4, 2024
Member
brandtbucher
left a comment
There was a problem hiding this comment.
Thanks for this! I'll leave it open for a bit in case others have thoughts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had some discussion in #111744 and in discord channel. We know this is a breaking change but people agree it's much more intuitive.
This basically changes the
breakpoint()andpdb.set_trace()behavior so it stops immediately after the call, rather than before the next line.Unfortunately a lot of the test cases need to be adapted.
breakpointdoes not enter pdb until the "next event" happens #111744📚 Documentation preview 📚: https://cpython-previews--118579.org.readthedocs.build/