reduce emphasis on virtualenv#606
Merged
Merged
Conversation
pfmoore
approved these changes
Apr 20, 2019
pradyunsg
approved these changes
Apr 20, 2019
Member
|
@theacodes This looks good to me, but the file name change has the potential to break incoming links. Do you still have something set up in nox to detect & add the redirects to deal with that? (I remember we had to turn it off in CI because it had trouble coping with new sections being added to existing pages) |
Member
|
Yes, this will definitely break links. I can either add redirects after this is merged or we can keep the old file name. I have no preference. I turned off the link checker when we stopped having so much churn. |
theacodes
approved these changes
Apr 21, 2019
Member
|
I think the canonical URL change makes sense, so if you're happy to add the redirects, let's go ahead! |
Member
|
It helps if I push the right button... |
Member
|
Cool, docs have been built and the redirect is in place. Thanks, everyone! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
virtualenvwithvirtual environmentwhen referring to a virtual environmentvirtualenvwhen referring to the tool.