Make lean3 an alias of Lean - #2546
Merged
Merged
Conversation
Collaborator
|
This is broken now as I merged the other lean change. Would you mind rebasing this? |
At some point there might be a push to make `lean` refer to Lean 4. This is consistent with how `python2` is used for Python 2 code.
eric-wieser
force-pushed
the
lean3-alias
branch
from
October 25, 2023 18:39
115d7f7 to
b04b0aa
Compare
Contributor
Author
|
Done |
Contributor
|
Looks good, but could you also add a definition |
Contributor
|
(Hello @PatrickMassot :) |
Contributor
Author
|
@jeanas: does the commit I just pushed look ok? |
Contributor
|
Almost — |
Contributor
Author
|
Done; this results in the mapping file being updated too, but I guess that's ok? |
Contributor
Author
|
Adding such an alias to |
Contributor
|
Yes, it's ok. However, it now complains that there are several conflicting lexers for the same file types. Never mind, I'll fix it. |
Contributor
Author
|
I think I found the fix |
Contributor
|
Yes, looks right now. |
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At some point there might be a push to make
leanrefer to Lean 4. This is consistent with howpython2is used for Python 2 code.