Skip to content

52 fileexistserror#53

Merged
Chilipp merged 2 commits intodevelopfrom
52-fileexistserror
Aug 15, 2022
Merged

52 fileexistserror#53
Chilipp merged 2 commits intodevelopfrom
52-fileexistserror

Conversation

@Chilipp
Copy link
Member

@Chilipp Chilipp commented May 18, 2022

When creating directories, this fix now always adds the parameter exists_ok=True to the call of os.makedirs

  • Fully documented, including CHANGELOG.rst for all changes

@schlunma, it would be great if you could verify that this fix closes #52

@Chilipp Chilipp self-assigned this May 18, 2022
@schlunma schlunma mentioned this pull request May 18, 2022
Merged
11 tasks
@valeriupredoi
Copy link

valeriupredoi commented May 18, 2022

@Chilipp many thanks for the fix 🍺

@schlunma
Copy link

schlunma commented May 18, 2022

@Chilipp Thanks for the quick fix!!

Unfortunately, we don't have a reliable method to reproduce this error, but the fix looks fine to me! We'll get back to you when we that problem still appears in our tests once the package is update 👍

@Chilipp Chilipp merged commit a5d8114 into develop Aug 15, 2022
@Chilipp Chilipp deleted the 52-fileexistserror branch August 15, 2022 07:29
@valeriupredoi
Copy link

valeriupredoi commented Aug 22, 2022 •
edited
Loading

@Chilipp many thanks for the fix - will you be releasing a new version soon to include this fix, please? 1.4.2 is the one we're picking up in our env and the occasional FileExistsError is still popping up here and there, see eg this recent test - many thanks for your work, mate! 🍺

@Chilipp
Copy link
Member Author

Chilipp commented Aug 23, 2022

alright, sorry for this delay! I will make a new release within this week @valeriupredoi

@valeriupredoi
Copy link

valeriupredoi commented Aug 23, 2022

not a problem at all, my apologies for pestering you 😁 Many thanks, mate 🍺

@Chilipp Chilipp mentioned this pull request Aug 26, 2022
Merged
Chilipp added a commit that referenced this pull request Aug 26, 2022
@Chilipp
[semver:patch] Minor fix for grid files
131e7dc 
# Fixed

Minor fix for grid files (#53)
@Chilipp
Copy link
Member Author

Chilipp commented Aug 27, 2022

Fyi @valeriupredoi Version 1.4.3 has been released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Chilipp Chilipp

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

FileExistsError error when psyplot is imported from multiple parallel processes

3 participants

@Chilipp @valeriupredoi @schlunma