bug fix and allow different decoder arguments #20
Merged
Chilipp merged 4 commits intopsyplot:masterfrom Apr 9, 2020
Merged
Conversation
This commit fixes a bug when speciying x, y, z and t as input arguments to a CFDecoder instance. Furthermore, we the decoder parameter for the from_dataset method now supports different input types, a None, a CFDecoder instance, a CFDecoder class and keyword arguments as a python dict
Codecov Report
@@ Coverage Diff @@
## master #20 +/- ##
==========================================
+ Coverage 79.82% 79.87% +0.05%
==========================================
Files 16 16
Lines 5560 5565 +5
==========================================
+ Hits 4438 4445 +7
+ Misses 1122 1120 -2
Continue to review full report at Codecov.
|
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug when speciying x, y, z and t as input arguments to a CFDecoder instance. Furthermore, the
decoderparameter for thefrom_datasetmethod now supports different input types,Noneto automatically set the decodera
psyplot.data.CFDecoderinstancea
psyplot.data.CFDecoder(sub)classkeyword arguments as a python
dictTests added (for all bug fixes or enhancements)
Tests passed (for all non-documentation changes)
Fully documented, including
CHANGELOG.rstfor all changes