fix(server): strip port before wildcard host match#1388
Open
dwisiswant0 wants to merge 1 commit into
Open
Conversation
Wildcard root-TLD logging matched configured domains against the raw Host header. HTTPS requests commonly include the default port in Host, such as "foo.bar.com:443", which prevented the suffix match from recognizing the configured domain and skipped interaction storage. Strip a syntactic Host port only for the domain match while preserving the original Host value in the recorded interaction. Fixes #1387 Signed-off-by: Dwi Siswanto <git@dw1.io>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wildcard root-TLD logging matched configured
domains against the raw Host header. HTTPS
requests commonly include the default port in Host,
such as "foo.bar.com:443", which prevented the
suffix match from recognizing the configured
domain and skipped interaction storage.
Strip a syntactic Host port only for the domain
match while preserving the original Host value in
the recorded interaction.
Fixes #1387