fix content length calculation in git objects blob header#1439
Merged
ben merged 1 commit intoprogit:masterfrom Jun 16, 2020
Merged
fix content length calculation in git objects blob header#1439ben merged 1 commit intoprogit:masterfrom
ben merged 1 commit intoprogit:masterfrom
Conversation
Member
|
Brilliant! I'm not terribly surprised that a Unicode issue snuck in, that's a blind spot we English-speaking Americans tend to have. Thanks! |
max123kl
added a commit
to max123kl/progit2-de_main
that referenced
this pull request
Jul 3, 2020
Co-Authored-By: Osman Khwaja <osman.khwaja@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, first time contributing so please bear with me if I missed something.
When testing out some code based on the contents of the internals section, I believe I ran into a small mistake. The header should contain the size in bytes of the content, but
content.lengthin the example returns the number of characters. Usingbytesizereturns the right value: https://ruby-doc.org/core-2.4.0/String.html#method-i-bytesizeThe example works with its content (
what is up, doc?) but the issue manifests with other charactersAs expected they result in different sha's. The correct one is the one using
bytesizeThis PR just tweaks the example to use
bytesizeinstead of length