Skip to content

add security warning about SSH port forwarding and show how to prevent it#1162

Closed
vlt wants to merge 1 commit intoprogit:masterfrom
vlt:master
Closed

add security warning about SSH port forwarding and show how to prevent it#1162
vlt wants to merge 1 commit intoprogit:masterfrom
vlt:master

Conversation

@vlt
Copy link
Copy Markdown

@vlt vlt commented Jan 14, 2019

No description provided.

Copy link
Copy Markdown
Contributor

@aollier aollier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One rule we impose on ourselves is: put a single sentence per line.
Furthermore, I don't remember that we cut a sentence in several lines.

Don't forget to remove the trailing spaces at the end of the line when you insert a new line.

Copy link
Copy Markdown
Contributor

@aollier aollier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This review is about layout of sentences:

  • Make a single sentence per line.
  • Do not cut a sentence into several lines.

Connection to gitserver closed.
----

At this point users are still able to use SSH port forwarding to access any
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not cut this sentence in several lines.

----

At this point users are still able to use SSH port forwarding to access any
host the git server is able to reach. If you want to prevent that you can edit
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Start the new sentence in a new line and finish the sentence in the same line.

@AnitaSDees
Copy link
Copy Markdown

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants