Print the filename during errors#209
Merged
certik merged 3 commits intoprefix-dev:mainfrom Jan 29, 2025
Merged
Conversation
Collaborator
Author
|
This now says: Which is very helpful to see the filename. |
Collaborator
Author
|
Ok, now it prints the filename unless it runs interactively, then it doesn't: @wolfv this is ready. |
Do not print it in interactive mode, but print it when running scripts.
Collaborator
Author
|
@wolfv should we merge this, and implement a better solution later using miette? |
Collaborator
Author
|
It looks like to do this using miette, we need to define our own source file in our error struct like this: Let's do that later. For now this unblocks us to print the filename, which is essential for debugging. I am going to merge this and we can further improve upon it. |
Collaborator
Author
|
Oops, the main failed after merging, since this PR was out of sync. Fixed in #217. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #208.