Add functionality for volumetric multiscale coupling to micro-mechanics simulations - #135
IshaanDesai wants to merge 78 commits into
Conversation
…le to another repo
MakisH
left a comment
There was a problem hiding this comment.
A first round of comments after reading through most files and mostly skimming through adapter/PreciceInterface.c and linstatic_precice.c. Let's go through these files together as well.
Some of my comments are not necessarily something to act upon, just something for my own understanding.
| int i, idx; | ||
| // Loop through all element and respective gauss points | ||
| for (i = 0; i < numIPTotal; i++) { | ||
| idx = i * 6 + strainIdx; //TODO: Add explanation for 6 |
There was a problem hiding this comment.
yes, please. Two similar points below.
There was a problem hiding this comment.
A summary of the preCICE-related changes would be helpful when upgrading to newer CalculiX versions.
| *sim->dtheta = 1; | ||
| *sim->theta = 0; | ||
| *sim->tper = 1; | ||
| //*sim->dtheta = 1; |
There was a problem hiding this comment.
Why removed?
Maybe fully remove?
| sim->iendset, | ||
| sim->ipkon, | ||
| sim->lakon, | ||
| *sim->lakon, |
There was a problem hiding this comment.
Is lakon a pointer?
Was this wrong before, or needed now because the type changed?
Does this need to be updated anywhere else?
|
I could be able to build the adapter by making these changes to the
to
Hope this helps. |
|
Thanks @MinhazPX for the suggestion. The build works now. I will look into the |
|
While trying to get this to work together with @MinhazPX, I noticed that the data structure It seems the current way of handling stress won't work. |
|
With reference to the previous comment, I am marking this pull request as draft because there is no clear solution for modifying stresses in CalculiX in sight. |
Sounds related to #111 |
This PR is derived from #118 and adds functionality for volumetric coupling to micro-mechanics simulations. The functionality is primarily contributed by @kalupaika. This PR is branched from the feature branch of #118 because #118 contains code specific to coupling a macro-scale CalculiX simulation with many micro-scale NASMAT simulations. This PR contains the functionality:
The implemented functionality is tested only for steady-state simulations. To incorporate the features for transient simulations, an appropriate test case would need to be devised.