Support for conda as a language by xhochy · Pull Request #1232 · pre-commit/pre-commit

xhochy · 2019-12-02T14:21:20Z

Example usage

.pre-commit-hooks.yaml:

- id: black-conda
  name: black-conda
  description: "Black: The uncompromising Python code formatter"
  entry: black
  language: conda
  require_serial: true
  types: [python]

environment.yml:

channels:
  - conda-forge
  - defaults
dependencies:
  - black=19.10b0

xhochy · 2019-12-02T14:21:59Z

This is lacking sufficient tests, I'm unsure what should be tested and am open for suggestions.

xhochy · 2019-12-03T06:25:58Z

This has now all review comments incorporated and tests are passing except for Windows. There we need to download a lightweight conda (take an exe from https://repo.anaconda.com/pkgs/misc/conda-execs/) to get the tests passing. This needs an modification of the Azure template like https://github.com/asottile/azure-pipeline-templates/blob/f8721c757e218487ca0bb38af0201b2a04e9ed52/job--python-tox.yml#L63-L68 @asottile Should I modify the template to always install a conda.exe on Windows or make this conditional on some parameter?

asottile · 2019-12-03T07:06:09Z

there's a pre_test list where you can install whatever you need 👍

for example, here's what it does to install ruby / swift on linux:

pre-commit/azure-pipelines.yml

Lines 41 to 46 in 023b337

 pre_test: 

     - task: UseRubyVersion@0 

     - bash: | 

         testing/get-swift.sh 

         echo '##vso[task.prependpath]/tmp/swift/usr/bin' 

       displayName: install swift

asottile

seems good!

xhochy · 2019-12-04T09:19:27Z

@asottile Adjusted all things and CI is still green. :)

asottile · 2019-12-04T16:57:34Z

+
+@contextlib.contextmanager
+def in_env(prefix, language_version):
+    helpers.assert_version_default('conda', language_version)


this should be part of install_environment I believe

Should these be removed here then?

yes -- you can take precedent from the other languages that use this function

xhochy · 2019-12-06T09:15:43Z

@asottile Azure is failing with missing files in the template repo but these actually exist. Do you have an idea what is going wrong here?

asottile · 2019-12-06T17:04:51Z

@asottile Azure is failing with missing files in the template repo but these actually exist. Do you have an idea what is going wrong here?

huh they must have changed the inclusion rules :/

asottile · 2019-12-06T17:09:16Z

I'm trying to fix that in #1234 -- we'll see!

asottile · 2019-12-06T17:51:56Z

ok if you rebase on master it should fix the CI

asottile

looks good! can probably squash the commits (if you want, don't need to though and don't feel obligated to)

I'm going to take this for a spin locally and then probably merge (so probably within a few days)!

thanks again for the work on this 🎉

xhochy force-pushed the conda-language branch 2 times, most recently from 30ed0d1 to 79779be Compare December 2, 2019 16:13

asottile reviewed Dec 2, 2019

View reviewed changes

Comment thread pre_commit/languages/conda.py Outdated

Comment thread pre_commit/languages/conda.py

Comment thread pre_commit/languages/conda.py

Comment thread tests/repository_test.py

asottile reviewed Dec 2, 2019

View reviewed changes

Comment thread testing/resources/conda_hooks_repo/.pre-commit-hooks.yaml Outdated

asottile reviewed Dec 2, 2019

View reviewed changes

Comment thread pre_commit/languages/conda.py Outdated

asottile reviewed Dec 2, 2019

View reviewed changes

Comment thread tests/repository_test.py Outdated

xhochy force-pushed the conda-language branch 10 times, most recently from 5aba042 to f7144ad Compare December 3, 2019 16:09

asottile reviewed Dec 3, 2019

View reviewed changes

Comment thread pre_commit/languages/conda.py

Comment thread pre_commit/languages/conda.py

asottile reviewed Dec 4, 2019

View reviewed changes

xhochy force-pushed the conda-language branch from ebdac73 to 4682d03 Compare December 6, 2019 09:06

asottile reviewed Dec 6, 2019

View reviewed changes

Comment thread pre_commit/languages/conda.py

xhochy force-pushed the conda-language branch from 4682d03 to ba021aa Compare December 9, 2019 09:37

asottile approved these changes Dec 9, 2019

View reviewed changes

Support for conda as a language

4ff23b4

asottile force-pushed the conda-language branch from ba021aa to 4ff23b4 Compare December 21, 2019 02:47

asottile merged commit 0ecd50b into pre-commit:master Dec 21, 2019

xhochy deleted the conda-language branch January 12, 2020 15:31

lorenzwalthert mentioned this pull request Mar 27, 2020

Explore possibility of distributing hooks via conda in addition to script lorenzwalthert/precommit#119

Closed

lorenzwalthert mentioned this pull request Nov 1, 2020

Support for manual dependency management for local repos, system or script entry-points pre-commit-ci/issues#13

Open

lorenzwalthert mentioned this pull request Feb 15, 2021

Support for R / renv as a language #1799

Merged

Uh oh!

Uh oh!

Conversation

xhochy commented Dec 2, 2019

Example usage

Uh oh!

xhochy commented Dec 2, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

xhochy commented Dec 3, 2019

Uh oh!

asottile commented Dec 3, 2019

Uh oh!

asottile left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

xhochy commented Dec 4, 2019

Uh oh!

asottile Dec 4, 2019

Choose a reason for hiding this comment

Uh oh!

xhochy Dec 6, 2019

Choose a reason for hiding this comment

Uh oh!

asottile Dec 6, 2019

Choose a reason for hiding this comment

Uh oh!

xhochy commented Dec 6, 2019

Uh oh!

asottile commented Dec 6, 2019

Uh oh!

asottile commented Dec 6, 2019

Uh oh!

Uh oh!

asottile commented Dec 6, 2019

Uh oh!

asottile left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants