Refactor the initialization of GUC parameters. #1360
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
higuoxing
commented
Mar 6, 2024
| let task_json = format!(json_template!(), model, true); | ||
| let task: Value = serde_json::from_str(&task_json).unwrap(); | ||
| assert!(verify_task(&task).is_ok()); | ||
| assert!(verify_task(&task).is_err()); |
Contributor
Author
There was a problem hiding this comment.
In the initial commit of this test, this step should fail with RemoteCodeNotTrusted.
postgresml/pgml-extension/src/bindings/transformers/whitelist.rs
Lines 189 to 192 in f4e87c5
higuoxing
commented
Mar 6, 2024
| "Whether model can execute remote codes", | ||
| "", | ||
| &PGML_HF_TRUST_REMOTE_CODE.1, | ||
| GucContext::Userset, |
Contributor
Author
There was a problem hiding this comment.
Shall we make these GUCs SUSET?
SUSET options can be set at postmaster startup, with the SIGHUP mechanism, or from the startup packet or SQL if you're a superuser.
Managing GUC parameters in different places is hard to maintain. This patch organizes GUC definitions in a single place. Also, we use define_xxx_guc() APIs to define these parameters and it will allow us to manage GucContext, GucFlags in future. P.S., the test case test_trusted_model doesn't seem correct. I fixed it in this patch.
a868029 to
4612b4f
Compare
Contributor
Author
|
Merged in commit f674f70 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Managing GUC parameters in different places is hard to maintain. This patch organizes GUC definitions in a single place. Also, we use define_xxx_guc() APIs to define these parameters and it will allow us to manage GucContext, GucFlags in future.
P.S., the test case test_trusted_model doesn't seem correct. I fixed it in this patch.