update deeplink #1304
Merged
update deeplink #1304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
chillenberger
commented
Jan 25, 2024
- Remove hash from header id's, this was too conservative. We don't really us id's for styling anyway.
- Remove scroll spy. It is going away anyways and it uses quarySelector. querySelector id matching does not match css id character requirements causing querySelector DOMException: Failed to execute 'querySelector' on 'Element' errors for special character
- refine path/URI filtering for stripping .md. Github uses .md in url we were stripping this causing broken links.
- fmt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.