Skip to content

For max tokens using max new tokens instead of max_length #1220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SilasMarvin merged 1 commit into from
Dec 6, 2023
Merged

For max tokens using max new tokens instead of max_length #1220

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pgml-sdks/pgml/src/open_source_ai.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ mistralai/Mistral-7B-v0.1
let md5_digest = md5::compute(to_hash.as_bytes());
let fingerprint = uuid::Uuid::from_slice(&md5_digest.0)?;

let mut args = serde_json::json!({ "max_length": max_tokens, "temperature": temperature, "do_sample": true, "num_return_sequences": n });
let mut args = serde_json::json!({ "max_new_tokens": max_tokens, "temperature": temperature, "do_sample": true, "num_return_sequences": n });
if let Some(t) = chat_template
.or_else(|| try_get_model_chat_template(&model_name).map(|s| s.to_string()))
{
Expand Down Expand Up @@ -322,7 +322,7 @@ mistralai/Mistral-7B-v0.1
let md5_digest = md5::compute(to_hash.as_bytes());
let fingerprint = uuid::Uuid::from_slice(&md5_digest.0)?;

let mut args = serde_json::json!({ "max_length": max_tokens, "temperature": temperature, "do_sample": true, "num_return_sequences": n });
let mut args = serde_json::json!({ "max_new_tokens": max_tokens, "temperature": temperature, "do_sample": true, "num_return_sequences": n });
if let Some(t) = chat_template
.or_else(|| try_get_model_chat_template(&model_name).map(|s| s.to_string()))
{
Expand Down