Chatbot page is almost ready to go #1054
Conversation
| }); | ||
|
|
||
| impl Star { | ||
| pub fn new<S: ToString, I: Into<Option<S>>>(color: &str, content: S, id: I) -> Star { |
There was a problem hiding this comment.
I discovered this the other day:
fn something(content: impl ToString)
Seems cleaner than a generic notation.
| @@ -0,0 +1,13 @@ | |||
| import { Controller } from '@hotwired/stimulus' | |||
There was a problem hiding this comment.
You can delete empty controllers, bundle just won't include them.
There was a problem hiding this comment.
Yes I just removed this!
| toastElement.setAttribute('role', 'alert'); | ||
| toastElement.setAttribute('aria-live', 'assertive'); | ||
| toastElement.setAttribute('aria-atomic', 'true'); | ||
| const toastElement = document.createElement("div"); |
There was a problem hiding this comment.
Do you have a linter we could all install? It would be nice to have one tbh...
There was a problem hiding this comment.
I use prettier for javascript. I can setup a prettier configuration for our repos that will avoid things like this, but I'll also look into setting up eslint.
There was a problem hiding this comment.
Please yeah, any one of them works, as long as it's easy to use.
| glob = "*" | ||
| pgml-components = { path = "../packages/pgml-components" } | ||
| reqwest = { version = "0.11.20", features = ["json"] } | ||
| pgml = { version = "0.9.2", path = "../pgml-sdks/pgml/" } |
There was a problem hiding this comment.
Love monorepos! Things are just easier.
No description provided.