เพิ่ม e2e cucumber เคสที่เหลือ #36
Open
YIEMODDS wants to merge 34 commits intopoorprogrammer:masterfrom
Open
Conversation
…ices in Cucumber tests
…oices in Cucumber tests
… in duplicate quotation and receipt steps
juacompe
reviewed
Mar 30, 2025
Collaborator
juacompe
left a comment
There was a problem hiding this comment.
- steps definition มี duplicate เยอะ
- invoiceReciept ไม่มี จริง ๆ ต้องเป็น receipt
ที่เหลือดูดีหมดเลย
| await this.viewReceiptPage.containsDocumentNumber(receiptNumber); | ||
|
|
||
| this.invoicesToCleanup.push(invoice2); | ||
| this.invoiceReceiptsToCleanup.push(receiptNumber); |
Collaborator
There was a problem hiding this comment.
อันนี้ควรเป็น receiptsToCleanup ป่ะ?
| for (const invoice of this.invoicesToCleanup) { | ||
| await deleteInvoice(invoice, this); | ||
| } | ||
| for (const receipt of this.invoiceReceiptsToCleanup) { |
Collaborator
There was a problem hiding this comment.
อันนี้เป็น receipts แหละ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
เพิ่ม make file e2e-cucumber,load-data ให้ลบข้อมูลแล้ว set ข้อมูลใหม่ให้สะดวกต่อการ เขียน e2e
เพิ่ม e2e duplicate-invoice, duplicate-quotation, duplicate-receipt ,invoice, invoices
ทำให้การ cleanup data ไปทำตอน run แต่ละ scenario เสร็จ