Skip to content

EN #3183 allow null logs flag for python client #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eneumann merged 1 commit into from
Dec 5, 2024
Merged

EN #3183 allow null logs flag for python client #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions polyapi/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,13 +66,13 @@ def generate_command(args):
fn_add_parser.add_argument("--description", required=False, default="", help="Description of the function")
fn_add_parser.add_argument("--server", action="store_true", help="Marks the function as a server function")
fn_add_parser.add_argument("--client", action="store_true", help="Marks the function as a client function")
fn_add_parser.add_argument("--logs", choices=["enabled", "disabled"], default="disabled", help="Enable or disable logs for the function.")
fn_add_parser.add_argument("--logs", choices=["enabled", "disabled"], default=None, help="Enable or disable logs for the function.")
fn_add_parser.add_argument("--execution-api-key", required=False, default="", help="API key for execution (for server functions only).")
fn_add_parser.add_argument("--disable-ai", "--skip-generate", action="store_true", help="Pass --disable-ai skip AI generation of missing descriptions")

def add_function(args):
initialize_config()
logs_enabled = args.logs == "enabled"
logs_enabled = args.logs == "enabled" if args.logs else None
err = ""
if args.server and args.client:
err = "Specify either `--server` or `--client`. Found both."
Expand Down
9 changes: 6 additions & 3 deletions polyapi/function_cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import sys
from typing import Any, List
from typing import Any, List, Optional
import requests
from polyapi.generate import get_functions_and_parse, generate_functions
from polyapi.config import get_api_key_and_url
Expand All @@ -23,7 +23,7 @@ def function_add_or_update(
description: str,
client: bool,
server: bool,
logs_enabled: bool,
logs_enabled: Optional[bool],
generate: bool = True,
execution_api_key: str = ""
):
Expand All @@ -45,6 +45,9 @@ def function_add_or_update(
)
sys.exit(1)

if logs_enabled is None:
logs_enabled = parsed["config"].get("logs_enabled", None)

data = {
"context": context or parsed["context"],
"name": name,
Expand All @@ -54,7 +57,7 @@ def function_add_or_update(
"returnType": get_jsonschema_type(return_type),
"returnTypeSchema": parsed["types"]["returns"]["typeSchema"],
"arguments": [{**p, "key": p["name"], "type": get_jsonschema_type(p["type"]) } for p in parsed["types"]["params"]],
"logsEnabled": logs_enabled or parsed["config"].get("logs_enabled", False),
"logsEnabled": logs_enabled,
}

if server and parsed["dependencies"]:
Expand Down