Fix stacked area hide show bug #7668
Open
+48
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camdecoster
approved these changes
Dec 9, 2025
src/traces/scatter/plot.js
Outdated
Comment on lines
86
to
93
| // Clear any existing fill element references to ensure clean state | ||
| // This prevents stale references when fill configuration changes | ||
| trace._ownFill = null; | ||
| trace._nextFill = null; | ||
|
|
||
| var fillData = []; | ||
| if(trace._ownfill) fillData.push('_ownFill'); | ||
| if(trace._nexttrace) fillData.push('_nextFill'); |
Contributor
There was a problem hiding this comment.
Since you're making _ownFill and _nextFill null, the if checks will always fail. So, let's delete them.
Suggested change
| // Clear any existing fill element references to ensure clean state | |
| // This prevents stale references when fill configuration changes | |
| trace._ownFill = null; | |
| trace._nextFill = null; | |
| var fillData = []; | |
| if(trace._ownfill) fillData.push('_ownFill'); | |
| if(trace._nexttrace) fillData.push('_nextFill'); | |
| // Clear any existing fill element references to ensure clean state | |
| // This prevents stale references when fill configuration changes | |
| trace._ownFill = null; | |
| trace._nextFill = null; | |
| var fillData = []; |
Contributor
Author
There was a problem hiding this comment.
@camdecoster Tragically, _ownFill and _ownfill, as well as _nextFill and _nexttrace, are separate variables. 🙃
Contributor
There was a problem hiding this comment.
Ah, fair enough. I have words about this, but I won't include them here publicly.
…ide/show operations in legend
bcd7e49 to
44bc554
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7660
Fixes issue where some traces in stacked area charts were not rendering their fill correctly after certain sequences of hide/show operations in the legend.
Steps to test
Reproduce existing issue
Confirm that this PR fixes the issue
srcwith the build for this branch from the CI: https://output.circle-artifacts.com/output/job/c4caeb45-0a0b-4e23-97b6-ebb26b8561c8/artifacts/0/dist/plotly.js