fix scaling issue with image export#76
Merged
samizdatco merged 5 commits intoplotdevice:mainfrom May 23, 2025
Merged
Conversation
corrects issue where zoom percentages were being stored as a multiplier, meaning the image size was shrinking with each export
This reverts commit cf58a78.
This reverts commit 2dfb647.
- the `self.image["zoom"]` state field now uses 1.0 as 100% - the `self.imageZoom` outlet uses "100" as 100% - when exiting the modal, the zoom value is now persisted correctly (rather than accidentally being divided by 100)
Member
|
Thanks so much for diagnosing this so thoroughly! I think I've found a slightly more minimal fix by keeping the internal state in floating point (where 100%==1.0) and only translating to/from integer form when updating the text field. |
Contributor
Author
|
Your fix is much more straightforward, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrects issue where zoom percentages were being stored as a multiplier, meaning the image size was shrinking with each export
The bug was occurring because:
The UI showed zoom as a percentage (e.g., "100%")
The internal state converted this to a decimal (100%/100 → 1.0) for export
This decimal (1.0) was incorrectly saved back to the settings (1%)
On subsequent exports, this value was divided by 100 again (1%/100 → 0.01), resulting in increasingly small images
This has been fixed by converting back to a percentage before saving the zoom value