Add support for regex in allowed origins for the CORS filter.#13778
Open
alexdupre wants to merge 1 commit intoplayframework:mainfrom
Open
Add support for regex in allowed origins for the CORS filter.#13778alexdupre wants to merge 1 commit intoplayframework:mainfrom
alexdupre wants to merge 1 commit intoplayframework:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Helpful things
Purpose
This PR adds the ability to use regular expressions when defining the allowed origins for the CORS filter.
Background Context
Sometimes explicitely declaring all allowed origins is not possible, for example when dynamic hostnames under the same domain are used. Currently the only option is to allow any origin, but this is sub-optimal. I've evaluated two different approaches to solve the issue:
Considering that other common web frameworks (like Node Express) already support regular expressions, I've opted for the second solution.
The change has been done in a full backward compatible way, so the CORS behavior is unchanged unless the new
allowedOriginsAsRegexconfig parameter is set totrue.