Fix /auth/get response types - #162
Conversation
|
Fixes: #160 |
|
We're having this issue as well, anything I can do to help get it merged in? |
ntindall
left a comment
There was a problem hiding this comment.
@chris--young left a few comments - great catch and thank you for working on this.
|
|
||
| interface BaseResponse { | ||
| request_id: string; | ||
| status_code: number; |
There was a problem hiding this comment.
I don't believe status_code is returned in the base response
| account: string, | ||
| account_id: string, | ||
| routing: string, | ||
| write_routing: string |
There was a problem hiding this comment.
from the documentation for Auth see here this should be wire_routing
| } | ||
|
|
||
| interface ACHNumbers { | ||
| account: string, |
There was a problem hiding this comment.
nit: can we use ; as the trailing delimiter on the typings (as we do elsewhere in the file)?
| "bluebird": "^3.5.1", | ||
| "ramda": "0.23.x", | ||
| "request": "^2.74.0" | ||
| "request": "^2.74.0", |
There was a problem hiding this comment.
👍I believe this is the correct thing for us to do, given that we are exporting the typings from the package (for typescript clients, it will matter for those that do not install devDependencies).
|
@diit, we will merge it in as soon as the comments are addressed. Sorry for the delay! |
|
no worries about the delay, just made a few changes to address these comments also been having a hard time running getting this make file to work on windows might be willing to open up and issue and fix that if you think its worth it |
| /node_modules/ | ||
| /npm-debug.log | ||
| .env | ||
| .vs/ |
There was a problem hiding this comment.
you probably need to add this to your .gitignore_global file @chris--young
I don't mind it being comitted here as well, though.
Added a new response type for getAuth() since it should not use the same response type as getAccounts()
plaid.com/docs/api/#auth
Also moved types out of dev dependencies so that theyll be included with
npm install --save plaidto prevent missing types