Fix #18204 - Remove getInnodbPluginVersion() and refactor getInnodbFileFormat() for MariaDB compatibility#20262
Open
gs71 wants to merge 10 commits intophpmyadmin:QA_5_2from
Open
Fix #18204 - Remove getInnodbPluginVersion() and refactor getInnodbFileFormat() for MariaDB compatibility#20262gs71 wants to merge 10 commits intophpmyadmin:QA_5_2from
gs71 wants to merge 10 commits intophpmyadmin:QA_5_2from
Conversation
Simplified retrieval of InnoDB file format by removing unnecessary version check. Signed-off-by: Guido Selva guido.selva@gmail.com
Removed the getInnodbPluginVersion method and updated the getInnodbFileFormat method to handle version checks for MariaDB and MySQL. Signed-off-by: Guido Selva guido.selva@gmail.com
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
TIP This summary will be updated as you push new changes. Give us feedback
Remove type hinting from getInnodbFileFormat method. Signed-off-by: Guido Selva guido.selva@gmail.com
Signed-off-by: Guido Selva guido.selva@gmail.com
Removed test for getInnodbPluginVersion method. Signed-off-by: Guido Selva guido.selva@gmail.com
Signed-off-by: Guido Selva guido.selva@gmail.com
Signed-off-by: Guido Selva guido.selva@gmail.com
Signed-off-by: Guido Selva guido.selva@gmail.com
Signed-off-by: Guido Selva guido.selva@gmail.com
Signed-off-by: Guido Selva guido.selva@gmail.com
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Starting from version 10.10 MariaDB removed the system variable 'innodb_version' (https://jira.mariadb.org/browse/MDEV-28554), so clicking on the 'Operations' link produces an error in the SQL errors log (if enabled):
ERROR 1193: Unknown system variable 'innodb_version' : SELECT @@innodb_version
Fixes #18204
Before submitting pull request, please review the following checklist:
Signed-off-byline as described in our DCO. This ensures that the work you're submitting is your own creation.