fix: remove dead Suhosin warning from HomeController#20167
Open
somethingwithproof wants to merge 2 commits intophpmyadmin:masterfrom
Open
fix: remove dead Suhosin warning from HomeController#20167somethingwithproof wants to merge 2 commits intophpmyadmin:masterfrom
somethingwithproof wants to merge 2 commits intophpmyadmin:masterfrom
Conversation
2 tasks
williamdes
approved these changes
Feb 23, 2026
MauricioFauth
requested changes
Feb 24, 2026
MauricioFauth
requested changes
Feb 24, 2026
19f1fa4 to
62f9f9d
Compare
Contributor
Author
|
Addressed all three review comments:
Also updated |
62f9f9d to
3224cde
Compare
3224cde to
3766910
Compare
c9b66cb to
7b8d4d3
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #20167 +/- ##
============================================
- Coverage 63.49% 63.47% -0.02%
- Complexity 16060 16063 +3
============================================
Files 676 676
Lines 59891 59878 -13
============================================
- Hits 38028 38009 -19
- Misses 21863 21869 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
9b88d8f to
2da36ec
Compare
somethingwithproof
added a commit
to somethingwithproof/phpmyadmin
that referenced
this pull request
Mar 9, 2026
Remove the SuhosinDisableWarning configuration property, which warned about Suhosin PHP extension conflicts. Suhosin is unmaintained and no longer relevant to modern PHP environments. - Remove SuhosinDisableWarning from Settings.php (type shape, property, constructor assignment, toArray, setSuhosinDisableWarning method) - Remove from Descriptions.php, FeaturesForm.php, HomeController.php - Remove testSuhosinDisableWarning() and related test assertions - Update phpstan-baseline.neon and psalm-baseline.xml - Remove FAQ 2.8 Suhosin bullet; add note that Suhosin is no longer relevant - Add config.rst note that this option was removed Closes phpmyadmin#20167 Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
2da36ec to
0d9039e
Compare
williamdes
approved these changes
Mar 9, 2026
Member
williamdes
left a comment
There was a problem hiding this comment.
This looks good now, thank you
0d9039e to
c27c373
Compare
somethingwithproof
added a commit
to somethingwithproof/phpmyadmin
that referenced
this pull request
Mar 26, 2026
Remove the SuhosinDisableWarning configuration property, which warned about Suhosin PHP extension conflicts. Suhosin is unmaintained and no longer relevant to modern PHP environments. - Remove SuhosinDisableWarning from Settings.php (type shape, property, constructor assignment, toArray, setSuhosinDisableWarning method) - Remove from Descriptions.php, FeaturesForm.php, HomeController.php - Remove testSuhosinDisableWarning() and related test assertions - Update phpstan-baseline.neon and psalm-baseline.xml - Remove FAQ 2.8 Suhosin bullet; add note that Suhosin is no longer relevant - Add config.rst note that this option was removed Closes phpmyadmin#20167 Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
TIP This summary will be updated as you push new changes. Give us feedback
Member
|
@MauricioFauth could you please review this one? |
Remove the SuhosinDisableWarning configuration property, which warned about Suhosin PHP extension conflicts. Suhosin is unmaintained and no longer relevant to modern PHP environments. - Remove SuhosinDisableWarning from Settings.php (type shape, property, constructor assignment, toArray, setSuhosinDisableWarning method) - Remove from Descriptions.php, FeaturesForm.php, HomeController.php - Remove testSuhosinDisableWarning() and related test assertions - Update phpstan-baseline.neon and psalm-baseline.xml - Remove FAQ 2.8 Suhosin bullet; add note that Suhosin is no longer relevant - Add config.rst note that this option was removed Closes phpmyadmin#20167 Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
…e count Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
e8e4d4f to
519193f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deprecated:: 6.0.0directive todocs/config.rst, keeping original description textdocs/faq.rstSuhosinDisableWarningproperty in Settings.php as deprecated no-op to avoid a 540-entry Psalm baseline cascade from the type shape changeReplaces #20123 which had a corrupted branch push.
Test plan
phpunit tests/unit/Controllers/HomeControllerTest.phppassesphpstan analyse-- no errorspsalm --no-diff-- no errors