Fix inconsistencies in devices import/export - #4401
Open
Voriaz wants to merge 9 commits into
Open
Conversation
added 9 commits
February 20, 2025 20:29
…be updated even if similar
…ced in GUI device creation
…data validation if they are not provided (empty)
… was not trimed
Author
|
Hello, Second wave of fixes. Sorry if I should have made a second PR, but GH puts my new commits in this PR too...
I'm proposing the following fixes:
Seems to fix the following Issues: #3887 #2103 #1894 #3463 Thanks, A. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Here is my small contribution to fix some inconsistencies in devices import/export feature that were making export, modify and re-import impossible:
I'm proposing the following fixes:
Seems to fix Issues #2838 #4130 #2464 #1894
Please let me know if this is ok to be merged.
Thanks,
A.