Conversation
Member
|
I guess removing stuff from the interface is safe |
Member
Author
|
in this case yes. if it was implemented anywhere, consumers of the api
might rely on the methods so its technically still a BC. but i would be
really surprised if anybody implemented those interfaces and never told us.
|
Member
Author
|
ah, we even have this note, so really no worries: https://github.com/phpcr/phpcr/blob/master/doc/JCR_TO_PHPCR.txt#L310-L311 we should update that documentation when we are good, though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Principal is something from java.security, so its not jcr specific at all. meaning there is no infrastructure to build principals.
i guess we either need a factory method on the AccessControlManager or provide the trivial implementation in PHPCR directly so people can use
new.i wonder how the java side of this actually works, if its using all that fancy stuff to in the end do a string comparison because the principal name and the username used in the jackrabbit connection.