Show message when notifications are denied#58
Merged
iMattPro merged 2 commits intophpbb-extensions:mainfrom Jun 16, 2024
Merged
Show message when notifications are denied#58iMattPro merged 2 commits intophpbb-extensions:mainfrom
iMattPro merged 2 commits intophpbb-extensions:mainfrom
Conversation
14780d3 to
e5ad949
Compare
rxu
approved these changes
Jun 15, 2024
Signed-off-by: Matt Friedman <maf675@gmail.com> Fix Signed-off-by: Matt Friedman <maf675@gmail.com> fix Signed-off-by: Matt Friedman <maf675@gmail.com> fix Signed-off-by: Matt Friedman <maf675@gmail.com>
rxu
reviewed
Jun 16, 2024
| 'NOTIFY_WEBPUSH_UNSUBSCRIBE' => 'Unsubscribe', | ||
| 'NOTIFY_WEBPUSH_SUBSCRIBED' => 'Subscribed', | ||
| 'NOTIFY_WEBPUSH_DROPDOWN_TITLE' => 'Visit notifications settings to set your preferred push notifications.', | ||
| 'NOTIFY_WEBPUSH_SUB_DENIED' => 'Push Notifications Are Denied', |
Contributor
There was a problem hiding this comment.
Wondering if just usual "Information" is enough in popup title.
Signed-off-by: Matt Friedman <maf675@gmail.com>
rxu
approved these changes
Jun 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.