[ticket/17343] Display push notifications in user language#6693
[ticket/17343] Display push notifications in user language#6693marc1706 merged 3 commits intophpbb:masterfrom
Conversation
|
For the extension we did it this way phpbb-extensions/webpushnotifications#65 if it makes any sense. |
One of the reasons want to do this in the controller is to prevent having to reload language multiple times while sending out notifications. |
|
One thing to maybe add to this, although not totally related, is Emoji support. Apparently if Emoji's are in the notification's body/message (such as from a PM or Topic title), they appear as something like |
Thanks for the info, that should also be fixed :) |
|
We did this: phpbb-extensions/webpushnotifications#82 |
|
Also ended up with that: |
|
Usernames are also correctly displayed now. |
|
Are there any pros/cons to storing the rendered emoji in the DB like this is doing now vs. storing it as hex code like before and decoding it when sending the push notification out? Also it working for me too |
| $notification = $this->notification_manager->get_item_type_class($row_data['notification_type_name'], $row_data); | ||
|
|
||
| // Load users for notification | ||
| $this->user_loader->load_users($notification->users_to_query()); |
There was a problem hiding this comment.
Should you add [USER_IGNORE] as 2nd parameter here?
There was a problem hiding this comment.
I don't think that's needed and also not what is done in the board notifications.
There was a problem hiding this comment.
I was just asking because we use this same method in the other webpush class (the method class) and there we are using the 2nd parameter with USER_IGNORE
There was a problem hiding this comment.
Though that is before creating the notification. Here it's about displaying it correctly so there shouldn't be any of these left.
We're storing the notification data the same way we're storing it for board notifications so I think it's fine to leave it like this. |
Are we? I remember looking in a DB entry for the _notifications table and seeing the emoji as hex codes in there. |
You can compare the contents of the created notifications for these examples in the database. I've opted to generally use the same way of storing these so there shouldn't be a big difference. |
PHPBB-17343
Checklist:
Tracker ticket:
https://tracker.phpbb.com/browse/PHPBB-17343