[ticket/15790] Allow dynamic loading services files for extensions#5361
[ticket/15790] Allow dynamic loading services files for extensions#5361rxu wants to merge 2 commits intophpbb:masterfrom
Conversation
|
With this change you can't inherit and overwrite settings from other files anymore right? And it doesn't seem to check if it already loaded the file? |
|
In general, I don't get this change. The services are cached in the Container and it will only be rebuilt if the cache folder is cleared or extensions are enabled/disabled. |
As far as the files loading queue is not ordered, then rather right. Also you still can use
Didn't get the question. It actually loads services definitions from those files. Symfony handles them internally.
Sure. You disable the extension, drop in files, then enable the extension. Voila. |
Yeah, but you could also make another extension that extends it, can't you? |
|
With this change you don't need to create new extension every time you need to make an addition to another extension. |
|
What I can say additionally is that with this change extension developer is free to decide if to use this feature or not. |
|
@marc1706 Can we probably make a decision on this PR? |
PHPBB3-15790
Checklist:
Tracker ticket (set the ticket ID to your ticket ID):
PHPBB3-15790.