Add all and any expected conditions#777
Open
barbaris-in wants to merge 12 commits intophp-webdriver:mainfrom
Open
Add all and any expected conditions#777barbaris-in wants to merge 12 commits intophp-webdriver:mainfrom
all and any expected conditions#777barbaris-in wants to merge 12 commits intophp-webdriver:mainfrom
Conversation
williamdes
approved these changes
Mar 22, 2020
Collaborator
williamdes
left a comment
There was a problem hiding this comment.
The diff looks good to me, could you add some tests for the 2 new functions ?
williamdes
reviewed
Mar 22, 2020
williamdes
reviewed
Mar 22, 2020
williamdes
suggested changes
Mar 22, 2020
Collaborator
williamdes
left a comment
There was a problem hiding this comment.
Thank you the new tests 💯
Author
|
Should I add some functional tests? |
williamdes
reviewed
Mar 22, 2020
williamdes
reviewed
Mar 22, 2020
williamdes
reviewed
Mar 22, 2020
Collaborator
@OndraM what do you recommend ? |
williamdes
approved these changes
Mar 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Along with a
notcondition would be great to haveandandorconditions. I called themallandanyrespectively